<html>
<head><meta charset="utf-8"><title>refactoring chalk · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html">refactoring chalk</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="162136977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/162136977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#162136977">(Mar 30 2019 at 20:09)</a>:</h4>
<p>fyi, I'm mostly afk this week, but i'm doing various bits of refactoring on chalk trying to turn it into an on-demand, query-driven system. This is requiring a bit more experimentation than anticipated. (cc <span class="user-mention" data-user-id="131694">@scalexm</span> -- I don't think you had much work-in-progress here, right?)</p>



<a name="162137036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/162137036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scalexm <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#162137036">(Mar 30 2019 at 20:10)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I did have a bit of work-in-progress, but I was mostly getting acquainted with salsa actually</p>



<a name="162614418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/162614418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#162614418">(Apr 05 2019 at 11:36)</a>:</h4>
<p>ps, still, mostly afk, but in case you're curious you can see my progress in <a href="https://github.com/nikomatsakis/chalk-ndm/tree/queryify" target="_blank" title="https://github.com/nikomatsakis/chalk-ndm/tree/queryify">my querify branch</a> -- I haven't gotten to the actual <em>queries</em> yet, but I've mostly disentangled the various interdependencies between the rust-ir, rules, etc so that there are smaller pieces that can be recombined. I'm just now getting to the deeper changes.</p>



<a name="163005115"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163005115" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163005115">(Apr 10 2019 at 13:40)</a>:</h4>
<p>PR posted <a href="https://github.com/rust-lang/chalk/pull/211" target="_blank" title="https://github.com/rust-lang/chalk/pull/211">https://github.com/rust-lang/chalk/pull/211</a></p>



<a name="163005168"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163005168" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163005168">(Apr 10 2019 at 13:41)</a>:</h4>
<p>I think what makes sense is that I should try to sketch out the end-state I envision as well as the current state</p>



<a name="163005169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163005169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163005169">(Apr 10 2019 at 13:41)</a>:</h4>
<p>I've been contemplating the right sort of diagrams for this :)</p>



<a name="163005170"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163005170" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163005170">(Apr 10 2019 at 13:41)</a>:</h4>
<p>It's a rather long PR</p>



<a name="163005185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163005185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163005185">(Apr 10 2019 at 13:41)</a>:</h4>
<p>and maybe then we should try to dig into that in either a recorded Zoom call or a sync Zulip meeting</p>



<a name="163005260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163005260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163005260">(Apr 10 2019 at 13:42)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="129457">@Florian Diebold</span> and <span class="user-mention" data-user-id="133169">@matklad</span>, this is relevant to rust-analyzer</p>



<a name="163005309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163005309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163005309">(Apr 10 2019 at 13:42)</a>:</h4>
<blockquote>
<p>It's a rather long PR</p>
</blockquote>
<p>what I meant by this is that I would expect it to be hard to follow without understanding what I was going for (and, in some cases, I was just opportunistically doing refactorings without knowing where I was going :)</p>



<a name="163005362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163005362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163005362">(Apr 10 2019 at 13:43)</a>:</h4>
<p>cc <span class="user-group-mention" data-user-group-id="692">@WG-traits</span> <span aria-label="point up" class="emoji emoji-1f446" role="img" title="point up">:point_up:</span></p>



<a name="163006131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163006131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scalexm <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163006131">(Apr 10 2019 at 13:52)</a>:</h4>
<p>Big PR indeed</p>



<a name="163006159"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163006159" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scalexm <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163006159">(Apr 10 2019 at 13:53)</a>:</h4>
<p>I quickly skimmed through it, but I’ll have a deeper look within the next few days</p>



<a name="163184766"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163184766" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163184766">(Apr 12 2019 at 12:35)</a>:</h4>
<p>So <span class="user-group-mention" data-user-group-id="692">@WG-traits</span> -- what do you y'all think about using the meeting on monday (perhaps extended to 1hour) to discuss this in more depth? (Over Zulip, I imagine)</p>
<p>I can try to prepare a brief write-up with the structure I created and some of the things I think we still have yet to do. (I spent some time today thinking about how best to diagram it, I'd like to have some documentation of this for future humans who might like to read the source.)</p>



<a name="163184966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactoring%20chalk/near/163184966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactoring.20chalk.html#163184966">(Apr 12 2019 at 12:38)</a>:</h4>
<p>As a potential future human, I would appreciate the diagram :) I feel like chalk integration would be the point where I stop understanding fully how rust-analyzer works )</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>